refactor(workflow-core): remove unused hadoop Iceberg catalog#6315
Open
anthonychengit wants to merge 2 commits into
Open
refactor(workflow-core): remove unused hadoop Iceberg catalog#6315anthonychengit wants to merge 2 commits into
anthonychengit wants to merge 2 commits into
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
1 similar comment
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6315 +/- ##
============================================
+ Coverage 61.02% 63.40% +2.37%
+ Complexity 3375 2219 -1156
============================================
Files 1140 870 -270
Lines 44923 36569 -8354
Branches 4942 3798 -1144
============================================
- Hits 27413 23185 -4228
+ Misses 16001 12316 -3685
+ Partials 1509 1068 -441
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🔴 | bs=10 sw=10 sl=64 | 437 | 0.267 | 22,337/30,102/30,102 us | 🔴 +9.5% / ⚪ within ±5% |
| 🔴 | bs=100 sw=10 sl=64 | 938 | 0.573 | 104,456/139,388/139,388 us | 🔴 +16.8% / ⚪ within ±5% |
| ⚪ | bs=1000 sw=10 sl=64 | 1,096 | 0.669 | 914,926/965,038/965,038 us | ⚪ within ±5% / ⚪ within ±5% |
Baseline details
Latest main 45c82a5 from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 437 tuples/sec | 460 tuples/sec | n/a | -5.0% | n/a |
| bs=10 sw=10 sl=64 | MB/s | 0.267 MB/s | 0.281 MB/s | n/a | -5.0% | n/a |
| bs=10 sw=10 sl=64 | p50 | 22,337 us | 20,404 us | n/a | +9.5% | n/a |
| bs=10 sw=10 sl=64 | p95 | 30,102 us | 32,904 us | n/a | -8.5% | n/a |
| bs=10 sw=10 sl=64 | p99 | 30,102 us | 32,904 us | n/a | -8.5% | n/a |
| bs=100 sw=10 sl=64 | throughput | 938 tuples/sec | 967 tuples/sec | n/a | -3.0% | n/a |
| bs=100 sw=10 sl=64 | MB/s | 0.573 MB/s | 0.59 MB/s | n/a | -2.9% | n/a |
| bs=100 sw=10 sl=64 | p50 | 104,456 us | 107,317 us | n/a | -2.7% | n/a |
| bs=100 sw=10 sl=64 | p95 | 139,388 us | 119,307 us | n/a | +16.8% | n/a |
| bs=100 sw=10 sl=64 | p99 | 139,388 us | 119,307 us | n/a | +16.8% | n/a |
| bs=1000 sw=10 sl=64 | throughput | 1,096 tuples/sec | 1,088 tuples/sec | n/a | +0.7% | n/a |
| bs=1000 sw=10 sl=64 | MB/s | 0.669 MB/s | 0.664 MB/s | n/a | +0.8% | n/a |
| bs=1000 sw=10 sl=64 | p50 | 914,926 us | 924,960 us | n/a | -1.1% | n/a |
| bs=1000 sw=10 sl=64 | p95 | 965,038 us | 957,712 us | n/a | +0.8% | n/a |
| bs=1000 sw=10 sl=64 | p99 | 965,038 us | 957,712 us | n/a | +0.8% | n/a |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,457.63,200,128000,437,0.267,22336.84,30102.09,30102.09
1,100,10,64,20,2131.92,2000,1280000,938,0.573,104456.43,139388.10,139388.10
2,1000,10,64,20,18244.01,20000,12800000,1096,0.669,914925.79,965038.49,965038.49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR removes the unused
hadoopIceberg catalog type.Changes:
hadoopcatalog branch fromIcebergCatalogInstance.IcebergUtil.createHadoopCatalog.HadoopCatalogimport while keepingHadoopFileIO.IcebergTableWriterSpecto use the supported postgres catalog helper.storage.confcatalog-type comment fromhadoop, rest, or postgrestorest or postgres.Any related issues, documentation, discussions?
Closes #6150
How was this PR tested?
Tested with:
sbt "WorkflowCore / scalafmtOnly"sbt "WorkflowCore / compile"Also attempted:
sbt "WorkflowCore / testOnly org.apache.texera.amber.core.storage.result.iceberg.IcebergTableWriterSpec"Was this PR authored or co-authored using generative AI tooling?
Generated-by: ChatGPT was used for planning and review assistance. I reviewed and tested the final code before submission.